fix: verify Svix signatures before forwarding webhook payloads#224
Draft
bukinoshita wants to merge 1 commit intomainfrom
Draft
fix: verify Svix signatures before forwarding webhook payloads#224bukinoshita wants to merge 1 commit intomainfrom
bukinoshita wants to merge 1 commit intomainfrom
Conversation
- Capture signing_secret from resend.webhooks.create() response - Add verifyPayload() that calls resend.webhooks.verify() with the signing secret before forwarding traffic to the local target - Reject unverified requests with 401 instead of blindly forwarding - Add --insecure-forward flag to explicitly skip verification - Display warning banner when --insecure-forward is active - Add comprehensive tests for signature verification behavior Fixes BU-646 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Verify Svix signatures in the
resend webhooks listenflow before forwarding to local targets, preventing spoofed webhook payloads. Fixes BU-646.signing_secretfromresend.webhooks.create()viaresend.webhooks.verify()with the raw body and Svix headers.{ "error": "signature_verification_failed" }.--insecure-forwardto skip verification (debug only) with a clear warning banner.Written for commit edd9625. Summary will update on new commits.